-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to the import system #2020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportDeclaration::importedSymbols
ImportDeclaration::importedSymbols
6d7ad11
to
e5acb25
Compare
faf7f9e
to
43565b3
Compare
43565b3
to
8380b24
Compare
ImportDeclaration::importedSymbols
8380b24
to
e588a24
Compare
konradweiss
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lshala
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the minor point, it LGTM
…d we resolve the import declaration back to the namespace (declaration) and update the symbol on-chance. Adding an 'import' edge
03a114d
to
1de14ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this PR is beginning to grow into something too big, so we probably want to merge it soon, but the problem is that things in the import / scope system are really tightly coupled. Hopefully a few things are now more de-coupled.
importedSymbols
statically once (or twice), instead we resolve the import declaration back to the namespace (declaration) and update the symbol on-chance. This still not the perfect solution that I want, but it's a step into the right direction.ResolveMemberExpressionAmbiguityPass
.resolveParentAlias
to take scope information into account