exception & syscall handler improvements #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regular asm! blocks are tricky because there's no guarantee that the compiler will emit them exactly once into the binary. This guarantee doesn't technically exist for global_asm! either, but the compiler is much more restricted in the optimizations (e.g. inlining) it can perform.
There's no good reason to save and restore caller-saved registers.
Previously we have to initialize it everytime because the compiler was allowed to instantiate the inline assembly more than once. This is technically still true, but doesn't matter much because there's no surrounding relevant context (e.g. code in a function the asm block was inlined into that could be present for normal inline assembling block).
Much like with the syscall entrypoint, now that we use global_asm! we can rely on a single address for the label.
The Rust compiler assumes that the direction flag is unset.
Freax13
force-pushed
the
fix/exception-handlers
branch
from
e136217 to
351dcba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.