Change CREATE_NEW_WINDOW IPC call to accept a path and query #6595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
requested changes
Jan 18, 2025
Co-authored-by: PikachuEXE <[email protected]>
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 19, 2025
PikachuEXE
approved these changes
Jan 20, 2025
ChunkyProgrammer
approved these changes
Jan 20, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jan 21, 2025
* development: (23 commits) Translated using Weblate (Czech) Translated using Weblate (German) Translated using Weblate (Basque) Translated using Weblate (Ukrainian) Translated using Weblate (German) Translated using Weblate (Basque) Translated using Weblate (German) Stay in fullscreen/fullwindow/PiP + default viewing mode setting (FreeTubeApp#5903) Undo Feature For Remove From Playlist. (FreeTubeApp#5885) group builds (FreeTubeApp#6497) Change CREATE_NEW_WINDOW IPC call to accept a path and query (FreeTubeApp#6595) Bump shaka-player from 4.12.7 to 4.12.8 (FreeTubeApp#6609) Bump electron from 33.3.1 to 34.0.0 (FreeTubeApp#6608) Translated using Weblate (French) Bump sass from 1.83.1 to 1.83.4 (FreeTubeApp#6607) Bump lefthook from 1.10.3 to 1.10.9 (FreeTubeApp#6606) Bump eslint-plugin-jsdoc from 50.6.1 to 50.6.2 in the eslint group (FreeTubeApp#6604) Translated using Weblate (Czech) Translated using Weblate (Estonian) Translated using Weblate (German) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CREATE_NEW_WINDOW IPC call to accept a path and query
Pull Request Type
Description
Currently the
CREATE_NEW_WINDOWIPC call accepts a URL and performs no validation on it, which means it can be used to open new windows with arbitrary URLs. This pull request locks it down by making it accept a path and query parameters instead, so that it can only be used to create windows with in-app URLs and adds some parameter validation.Testing
CREATE_NEW_WINDOWwith no parameters)test(path, query and searchQueryText) -> the search query text should appear in the search bar in the new windowDesktop