Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: increased color contrast for uploader comments in Catppuccin Moc… #6603

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

nanikh91
Copy link

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #6597

Description

This pull request improves the color contrast of the uploader's username in the Catppuccin Mocha theme to meet accessibility standards. The contrast for the username's highlight around comments from the uploader was previously too low. Now, it adheres to a higher contrast ratio, ensuring better readability and accessibility for users.

The fix modifies the CSS for the Catppuccin Mocha theme to make the uploader's comment more distinguishable, by adjusting the relevant colors used in the theme.

Screenshots

Before: (Screenshot showing the low contrast issue)
Image 19-01-2025 à 19 02

After: (Screenshot showing the improved contrast)
Image 19-01-2025 à 19 22 (1)

Testing

  • The changes were tested locally by running the FreeTube application and setting the theme to Catppuccin Mocha.
  • I verified that the color contrast of the uploader's name was improved across different environments.
  • There are no remaining ramifications or errors related to this fix.

Desktop

  • OS: macOS 11 (Big Sur)
  • OS Version: 11.5.1
  • FreeTube version: 0.22.1

Additional context

  • This fix was made in accordance with accessibility standards to ensure the readability of the uploader's name in the comments section for users with visual impairments.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 19, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 19, 2025 19:25
@kommunarr
Copy link
Collaborator

Thanks for looking into this! I do see that the new color contrast here appears to be 2.18:1, an improvement over the prior 1.07:1, but still a bit below the WCAG 2's advised 3:1.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: catppuccinMocha: Color contrast for owner comments is too low
3 participants