Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5476: Adjusted z-index for tooltips to avoid overlapping with top/bottom bar #6656

Conversation

sullivanlng
Copy link
Contributor

Title

Fix tooltip index to resolve overlap with bottom navigation bar

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #5476

Description

This pull request resolves an issue where tooltips were overlapping the bottom navigation bar on mobile devices.

Changes made:

  • Adjusted the tooltip index to 2 to ensure proper positioning on all devices, particularly for mobile users when scrolling.

Screenshots

Before :
tooltip1
tooltip2

After :
tooltip4
tooltip3

Testing

Approach:

  • Tested across multiple device sizes and resolutions using the toggle device bar.
    Behavior Confirmed:
  • The tooltip no longer overlaps with the bottom or top navigation bar.

Desktop

  • OS: Windows 11
  • OS Version: 23H2
  • FreeTube version: 0.22.1

Additional context

Initially changed the tooltip index to 3 but the bug was still present for mobile users.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 27, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 27, 2025 17:06
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@FreeTubeBot FreeTubeBot merged commit bf4d49e into FreeTubeApp:development Jan 27, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 27, 2025
SudharakaP pushed a commit to SudharakaP/FreeTube that referenced this pull request Jan 28, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jan 29, 2025
* development: (35 commits)
  Shrink mime-db even further (FreeTubeApp#6659)
  * Update play next recommended video setting to be "by default" (FreeTubeApp#6400)
  Miscellaneous performance improvements (FreeTubeApp#6658)
  Bump stylelint in the stylelint group across 1 directory (FreeTubeApp#6660)
  Bump the stylelint group across 1 directory with 4 updates (FreeTubeApp#6605)
  Fixes FreeTubeApp#5476: Adjusted z-index for tooltips to avoid overlapping with bars (FreeTubeApp#6656)
  Bump shaka-player from 4.12.8 to 4.13.0 (FreeTubeApp#6649)
  Migrate ProfileSettings, FtProfileBubble and FtProfileEdit to the composition API (FreeTubeApp#6639)
  Translated using Weblate (Arabic)
  Bump the eslint group with 4 updates (FreeTubeApp#6645)
  Bump bgutils-js from 3.1.2 to 3.1.3 (FreeTubeApp#6650)
  Translated using Weblate (Arabic)
  Translated using Weblate (Arabic)
  Bump electron from 34.0.0 to 34.0.1 (FreeTubeApp#6648)
  Bump lefthook from 1.10.9 to 1.10.10 (FreeTubeApp#6647)
  Bump the babel group with 2 updates (FreeTubeApp#6644)
  Translated using Weblate (Arabic)
  Avoid logging an error when a player cache entry does not exist (FreeTubeApp#6640)
  Move saving screenshots to the default folder to an IPC call (FreeTubeApp#6636)
  Replace rimraf dev dependency with clean script (FreeTubeApp#6638)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tooltip popup z-index inteferes with top/bottom bar
5 participants