Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xExtension-YouTube warnings in stream #222

Open
pax0707 opened this issue Mar 17, 2024 · 7 comments
Open

xExtension-YouTube warnings in stream #222

pax0707 opened this issue Mar 17, 2024 · 7 comments
Labels
xExtension-YouTube xExtension-YouTube

Comments

@pax0707
Copy link

pax0707 commented Mar 17, 2024

This happens when enabling "Display the feeds content" in extension options with latest extension and edge build.
Wasn't happening with the build few days ago when I was testing.

Warning: DOMDocument::loadHTML(): Tag figure invalid in Entity, line: 2 in /var/www/FreshRSS/extensions/xExtension-YouTube/extension.php on line 203

Warning: DOMDocument::loadHTML(): Tag figcaption invalid in Entity, line: 2 in /var/www/FreshRSS/extensions/xExtension-YouTube/extension.php on line 203

image

@math-GH math-GH added the xExtension-YouTube xExtension-YouTube label Mar 19, 2024
@karmicdude
Copy link

+1

@Alkarex
Copy link
Member

Alkarex commented Jan 16, 2025

Is it still a problem?

@pax0707
Copy link
Author

pax0707 commented Jan 16, 2025

@Alkarex yes @ 1.25.1-dev.

Image

@Alkarex
Copy link
Member

Alkarex commented Jan 16, 2025

Ping @kevinpapst or @ImAReplicant for a little help if you are around

@kevinpapst
Copy link
Collaborator

Yeah, I think Youtube change the embedded HTML and the PHP Doc Parser does not support HTML5 tags like figure.

That's what 8.4 brings in: https://www.php.net/releases/8.4/en.php#dom_additions_html5

Not sure what to do. Shall we add the @ shut up operator?

@Frenzie
Copy link
Member

Frenzie commented Jan 16, 2025

That's what 8.4 brings in

That sounds like the solution for the image proxy as well. But what to do in the meantime. :)

@Alkarex
Copy link
Member

Alkarex commented Jan 16, 2025

Related to FreshRSS/FreshRSS#6831
I think the approach is to start using the new PHP 8.4+ functions and define a fallback compatible with PHP 8.1 (using the old functions and hiding the errors at least). I will try to draft something in the core. In the meantime, hiding the errors would be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xExtension-YouTube xExtension-YouTube
Projects
None yet
Development

No branches or pull requests

6 participants