-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Youtube extension #217
Conversation
Help to test welcome (I am not a user myself), and optionally to finalise the light code upgrade (e.g. Ping @ImAReplicant |
Updated it yesterday. |
Hello, I never wanted to steal @kevinpapst's work, in fact I had opened an issue to ask if I could integrate the fork (#133 (comment)). I thought at the time that the extension was no longer maintained. The changes I've made concern peertube videos, because without my changes peertube videos wouldn't be integrated. In extension.php file, line 177 : As for the rest of the changes, it was an attempt to modify the display of the peertube description, but it doesn't seem to work anymore. Indeed, the description is displayed in a rather strange way: Sorry again for this misunderstanding and the problems it has caused. |
Thanks for your explanation @ImAReplicant From my end this is ready for merge, as @pax0707 confirmed that the current version works. Let's do the Peertube (how many people use that?) integration either in its own extension or at least in second PR. |
Could you please update https://github.com/FreshRSS/Extensions/blob/master/repositories.json accordingly? |
Done |
Thanks for accepting the extension! |
See #216
Dear Reviewer
I do not have a running FreshRSS installation for testing. The 8+ year old codebase was upgraded blindly to latest FreshRSS and "modern" PHP style, especially the code regarding user configuration handling needs testing. In other words: install before merge 😁