Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onCreate, onClose logs for talker_bloc_logger #162

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

cem256
Copy link
Contributor

@cem256 cem256 commented Nov 30, 2023

  • Add logging for the onCreate, onClose methods for the TalkerBlocObserver
  • Add printCreations, printClosings fields in TalkerBlocLoggerSettings
  • Use well known titles for titles (WellKnownTitles.blocCreate.title and WellKnownTitles.blocClose.title)

Screenshot 2023-11-30 at 23 41 59

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5f8720) 100.00% compared to head (06c63df) 100.00%.
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        10    -7     
  Lines          260       175   -85     
=========================================
- Hits           260       175   -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Frezyx
Copy link
Owner

Frezyx commented Dec 1, 2023

Hello @cem256 🤝
Great! I forgot to add logging for these events. Thank you for taking the time!
LGMT

@Frezyx Frezyx merged commit 9abfdf0 into Frezyx:master Dec 1, 2023
1 check passed
@Frezyx Frezyx linked an issue Jan 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve talker_bloc_logger by adding onChange, onCreate, onClose
3 participants