can bring your own history class #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 11 +1
Lines 173 183 +10
=========================================
+ Hits 173 183 +10 ☔ View full report in Codecov by Sentry. |
Frezyx
requested changes
Dec 12, 2023
Comment on lines
+3
to
+5
| class DefaultTalkerHistory implements TalkerHistory { | ||
| DefaultTalkerHistory(this.settings); | ||
|
|
There was a problem hiding this comment.
Can you provide documentation ?
(Public class)
Comment on lines
+30
to
+32
|
|
||
| abstract class TalkerHistory { | ||
| List<TalkerDataInterface> get history; |
There was a problem hiding this comment.
Can you provide documentation ?
(Public class)
|
Hello @Ppito ! |
fix(utils): add missing export file
# Conflicts: # packages/talker/lib/talker.dart
|
Sorry, I broke my git and pulled the wrong thing ... ignore this PR, I'll make another clean one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Frezyx,
I need to monitor my application and keep the log history to do some stuff on it. (Like, to bring back all the logs for our support operations).
So I've moved the logic of your history implementation into a class that I can override like I want.
By the way, I saw that you were thinking about a FileManager implementation, and I think we could use this approach. What do you thinks ?
And by extension, why not offer log history implementations directly with Isar, hive or SQFlite database?
In any case, by passing through a class we'll be free to make our own implementation of the history backup.