Add 7x as a Geolocation API Provider #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imorland
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Thank you for this contribution @meezaan :)
You raise a valid point on rate limit handling, which is something this extension needs to handle better for all providers, but I see no reason why this provider cannot be included ahead of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Added a new Service for the 7x API and updated the JS so the API key is also required for this API.
Reviewers should focus on:
Whether some error handling for rate limiting should be added. The free key allows for 20 requests a second, after which requests are all per second so there should be no reason for rate limiting on any paid plans.
Screenshot
Confirmed
composer test).