[RFC] feat: introduce new reverse_proxy_cache_control config to allow configuring specific cache control for reverse proxy #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
force-pushed
the
feat-reverse-proxy-control
branch
3 times, most recently
from
1457c2b to
2109df4
Compare
94noni
changed the title
94noni
force-pushed
the
feat-reverse-proxy-control
branch
3 times, most recently
from
3e1c45f to
d4638be
Compare
94noni
changed the title
94noni
force-pushed
the
feat-reverse-proxy-control
branch
2 times, most recently
from
a9e3d20 to
62e56b1
Compare
94noni
changed the title
94noni
force-pushed
the
feat-reverse-proxy-control
branch
3 times, most recently
from
7825d09 to
5a4c2fa
Compare
…guring specific cache control for reverse proxy
94noni
force-pushed
the
feat-reverse-proxy-control
branch
from
5a4c2fa to
40f7659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello 👋🏻
this is kind of a following PR of #638
we are in the process of leveraging fastly, and fastly waits same value as the
Cache-Controlone, thus we need some array values not one valuesee doc and doc
actually, its only stated to have an
integerin the doc forreverse_proxy_ttlwhich they translates to the proper header name for fastlyso as a hack for now, we arrive to do such things as:
'reverse_proxy_ttl' => 'max-age=' . 2592000 . ' , public',obviously, I do prefer to have a proper new config map (related to the normal
cache_control):for now no test or whatsoever, I just want to discuss the topic, so opening as an rfc
thx !