Fix unknown distribution message formatting #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the error is unformatted:
called 'Unknown or unsupported linux distribution: {0} (v{1})' if there
After this patch:
called 'Unknown or unsupported linux distribution: None (v1.1)' if there
I am not sure if the `None` is caused by my broken `/etc/os-release`
or if it will appear even on real unsupported distributions. In any
case, it is not caused by this commit. We would have to fix
`System.distribution()`.
|
This may not be needed? On RHEL the message is correctly formatted even without this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the error is unformatted:
After this patch:
I am not sure if the
Noneis caused by my broken/etc/os-releaseor if it will appear even on real unsupported distributions. In any case, it is not caused by this commit. We would have to fixSystem.distribution().