Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rafal/fetch all simulation data from file #2539

Closed
wants to merge 24 commits into from
Closed

Rafal/fetch all simulation data from file #2539

wants to merge 24 commits into from

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Jan 8, 2025

Linked Issues/PRs

Description

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

rymnc and others added 24 commits December 31, 2024 00:59
@rymnc
chore(gas_price_service_v1): strictly ensure last_recorded_height is …
cbc6dee 
…set, to avoid initial poll of da source
@rymnc
fix
dba77da
@rymnc
chore: add test for gas price service
3b60422
@rymnc
fix: remove unnecessary storage set, add test for uninit task instead
b151207
@rafal-ch
Adopt simulator to the latest changes in types
24569eb
@rafal-ch
Add new command
b553b2c
@rafal-ch
Use reflection to get fields
c74f4e6
@rafal-ch
Properly retrieve blob_fee_wei()
6f9d595
@rafal-ch
Properly fetch L1 fee for both algorithms
dbaceb8
@rafal-ch
Add some clarifying comments
c909cb4
@rafal-ch
Calculate fullness and bytes pre simulation
37f7611
@rafal-ch
Read L2 block data from file
e52014f
@rafal-ch
Clean up code structure
97ce5dd
@rafal-ch
Clean up some comments
9ebe803
@rafal-ch
Update generation of L1 data
a0464f1
@rafal-ch
Fix typo
8d07bfc
@rafal-ch
Introduce L2BlockData
602403b
@rafal-ch
Read L2 block heights from the csv file
18b9ae1
@rafal-ch
Initialize updater with proper block height
c6ce17d
@rafal-ch
Update X-axis labels on charts
0853b2e
@rafal-ch
Fix fullness drawing
ffb1bb0
@rafal-ch
Add tracing subscriber so we can see logs from the algorithm
d27d74c
@rafal-ch
Track capacity and max size per block
61236ff
@rafal-ch
Draw fullness not as percentage
12fc51e
@rymnc rymnc changed the base branch from chore/add-tests-for-v1-gas-service to chore/create-new-gas-price-simulation January 8, 2025 16:38
@rymnc rymnc changed the base branch from chore/create-new-gas-price-simulation to chore/add-tests-for-v1-gas-service January 8, 2025 16:38
@rymnc
Copy link
Member

rymnc commented Jan 8, 2025

@rafal-ch now that we have #2540 and #2538 is it okay to close this PR?

@rafal-ch
Copy link
Contributor Author

rafal-ch commented Jan 8, 2025

Yes, it's not needed anymore.

@rafal-ch rafal-ch closed this Jan 8, 2025
@rymnc rymnc deleted the rafal/fetch_all_simulation_data_from_file branch January 8, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx will be requested when the pull request is marked ready for review xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal will be requested when the pull request is marked ready for review Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner will be requested when the pull request is marked ready for review MitchTurner is a code owner

@rymnc rymnc Awaiting requested review from rymnc rymnc will be requested when the pull request is marked ready for review rymnc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafal-ch @rymnc