Lock-free latest_l2_height in gas price service
#2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-ch
requested review from
xgreenx,
Dentosal,
MitchTurner and
rymnc
as code owners
rafal-ch
added
no changelog
acerone85
reviewed
Jan 10, 2025
| .latest_l2_height | ||
| .lock() | ||
| .map_err(|err| anyhow::anyhow!("lock error: {:?}", err))?; | ||
| let latest_l2_height = self.latest_l2_height.load(Ordering::SeqCst); |
There was a problem hiding this comment.
Suggested change
| let latest_l2_height = self.latest_l2_height.load(Ordering::SeqCst); | |
| let latest_l2_height = self.latest_l2_height.load(Ordering::Acquire); |
SeqCst is not needed unless you have at least two atomic variables. The purpose of SeqCst is to make sure that different threads do not see updates to different variables in different order. See https://stackoverflow.com/questions/14861822/acquire-release-versus-sequentially-consistent-memory-order for an example.
(Just mentioning this, overall I think we can keep SeqCst)
acerone85
reviewed
Jan 10, 2025
| @@ -103,7 +107,7 @@ where | |||
| .filter_costs_that_have_values_greater_than_l2_block_height(da_block_costs)?; | |||
| tracing::debug!( | |||
| "the latest l2 height is: {:?}", | |||
| *self.latest_l2_height.lock().unwrap() | |||
| self.latest_l2_height.load(Ordering::SeqCst) | |||
There was a problem hiding this comment.
Suggested change
| self.latest_l2_height.load(Ordering::SeqCst) | |
| self.latest_l2_height.load(Ordering::Acquire) |
acerone85
reviewed
Jan 10, 2025
| .lock() | ||
| .map_err(|err| anyhow!("Error locking latest L2 block: {:?}", err))?; | ||
| *latest_l2_block = BlockHeight::from(height); | ||
| self.latest_l2_block.store(height, Ordering::SeqCst); |
There was a problem hiding this comment.
Suggested change
| self.latest_l2_block.store(height, Ordering::SeqCst); | |
| self.latest_l2_block.store(height, Ordering::Release); |
(see the corresponding comment on the load operation)
acerone85
approved these changes
Jan 10, 2025
|
small comments because I am picky about memory ordering :) , but overall LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
Mutexaround thelatest_l2_heightin the gas price service.Before requesting review