-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current pool gas to the node info endpoint #2550
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f5e1114
Add current pool gas to the node info endpoint
AurelienFT 15e7746
Merge branch 'master' into add_info_pool
xgreenx 6dbd902
Add more stats of the tx pool to node info
AurelienFT 009846b
fix insta test
AurelienFT 43f6683
Merge branch 'master' into add_info_pool
AurelienFT 6d3531c
fix schema
AurelienFT 6a4063a
fix schema 2
AurelienFT 7250cd6
fix: rename nb_transactions to tx_count
rymnc 0a7e149
Add max gas and max size of pool in node_info
AurelienFT af67056
rename tx pool shared state stats function
AurelienFT e3d2e69
Merge branch 'master' into add_info_pool
AurelienFT d165b74
Update stat on removal as well
xgreenx 10ed099
Merge branch 'master' into add_info_pool
xgreenx 58b801a
Merge branch 'master' into add_info_pool
MitchTurner a5ef689
add check stats in unit tests
AurelienFT b8ba0c6
tests: Add integration test for fetching the txpool stats
netrome 2a0b97c
chore: Appease Clippy-sama
netrome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...shots/fuel_core_client__client__schema__node_info__tests__node_info_query_gql_output.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,21 @@ | ||
--- | ||
source: crates/client/src/client/schema/node_info.rs | ||
expression: operation.query | ||
snapshot_kind: text | ||
--- | ||
query QueryNodeInfo { | ||
nodeInfo { | ||
utxoValidation | ||
vmBacktrace | ||
maxTx | ||
maxGas | ||
maxSize | ||
maxDepth | ||
nodeVersion | ||
txPoolStats { | ||
txCount | ||
totalGas | ||
totalSize | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to also add max gas and max size in bytes of the tx pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it in the general structure like
max_tx
currently exists. I feel like it should be on a sub structure either likePoolStats
or a new onePoolConfiguration
but as we want to backport this to the existing version I don't like breaking the existing fieldmax_tx
by moving it to a sub structure.