-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages for responses from committer #2609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
previously approved these changes
Jan 21, 2025
crates/services/gas_price_service/src/v1/da_source_service/block_committer_costs.rs
Outdated
Show resolved
Hide resolved
…ck_committer_costs.rs Co-authored-by: Aaryamann Challani <[email protected]>
xgreenx
reviewed
Jan 21, 2025
crates/services/gas_price_service/src/v1/da_source_service/block_committer_costs.rs
Outdated
Show resolved
Hide resolved
…ck_committer_costs.rs Co-authored-by: Green Baneling <[email protected]>
MitchTurner
changed the title
Do not try to deserialize invalid responses
Improve error messages for responses from committer
Jan 21, 2025
AurelienFT
approved these changes
Jan 21, 2025
xgreenx
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it only one request that we send?
To the committer? Yes. We used to also call the "latest" endpoint, but we changed how logic works. |
Merged
MitchTurner
added a commit
that referenced
this pull request
Jan 22, 2025
## Version v0.41.1 * fault_proving(compression): include block_id in da compressed block headers by @rymnc in #2551 * chore: Add myself and Andrea as codeowner for graphql API + related crates by @netrome in #2570 * fix(integration_tests): remove flake from produce_block__l1_committed_block_affects_gas_price by @rymnc in #2566 * bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis better by @MitchTurner in #2599 * Fix version compatibility error by @AurelienFT in #2608 * Improve error messages for responses from committer by @MitchTurner in #2609 * Update async processor tests by @rafal-ch in #2577 * The amount of returned dust coins is limited by factor relative to the amount of selected big coins by @rafal-ch in #2610 * fix(da_compression): invalid decompression of utxo id and CoinConfig fix by @rymnc in #2593 * Use latest gas price to estimate next price for tx pool checks by @MitchTurner in #2612 * Set Latest Recorded Height on startup by @MitchTurner in #2603 * Use latest gas price to estimate next block gas price during dry runs by @MitchTurner in #2615 * Check that fuel-core lib builds correctly without default features by @rafal-ch in #2594 * Expose indexation status in `NodeInfo` endpoint by @rafal-ch in #2595 **Full Changelog**: v0.41.0...v0.41.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
Include additional context about the response if deserialization fails
Checklist