Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for responses from committer #2609

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

MitchTurner
Copy link
Member

@MitchTurner MitchTurner commented Jan 21, 2025

Linked Issues/PRs

Description

Include additional context about the response if deserialization fails

Checklist

  • New behavior is reflected in tests

@MitchTurner MitchTurner marked this pull request as ready for review January 21, 2025 16:02
@MitchTurner MitchTurner self-assigned this Jan 21, 2025
@MitchTurner MitchTurner changed the title Do not try to deserialize invalid responses Improve error messages for responses from committer Jan 21, 2025
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only one request that we send?

@MitchTurner MitchTurner merged commit b0773e0 into master Jan 21, 2025
31 checks passed
@MitchTurner MitchTurner deleted the log-error-response-from-committer branch January 21, 2025 23:37
@MitchTurner
Copy link
Member Author

Is it only one request that we send?

To the committer? Yes. We used to also call the "latest" endpoint, but we changed how logic works.

@MitchTurner MitchTurner mentioned this pull request Jan 22, 2025
MitchTurner added a commit that referenced this pull request Jan 22, 2025
## Version v0.41.1

* fault_proving(compression): include block_id in da compressed block
headers by @rymnc in #2551
* chore: Add myself and Andrea as codeowner for graphql API + related
crates by @netrome in #2570
* fix(integration_tests): remove flake from
produce_block__l1_committed_block_affects_gas_price by @rymnc in
#2566
* bugfix: Improve the `BlockCommitterHttpApi` client to use `url` apis
better by @MitchTurner in
#2599
* Fix version compatibility error by @AurelienFT in
#2608
* Improve error messages for responses from committer by @MitchTurner in
#2609
* Update async processor tests by @rafal-ch in
#2577
* The amount of returned dust coins is limited by factor relative to the
amount of selected big coins by @rafal-ch in
#2610
* fix(da_compression): invalid decompression of utxo id and CoinConfig
fix by @rymnc in #2593
* Use latest gas price to estimate next price for tx pool checks by
@MitchTurner in #2612
* Set Latest Recorded Height on startup by @MitchTurner in
#2603
* Use latest gas price to estimate next block gas price during dry runs
by @MitchTurner in #2615
* Check that fuel-core lib builds correctly without default features by
@rafal-ch in #2594
* Expose indexation status in `NodeInfo` endpoint by @rafal-ch in
#2595


**Full Changelog**:
v0.41.0...v0.41.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants