Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin netlink-proto version #2623

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Pin netlink-proto version #2623

merged 4 commits into from
Jan 23, 2025

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Jan 22, 2025 •
edited
Loading

Description

Pin netlink-proto to not have any issue when releasing

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT added the no changelog Skip the CI check of the changelog modification label Jan 22, 2025
@AurelienFT AurelienFT marked this pull request as ready for review January 22, 2025 22:51
xgreenx
xgreenx previously approved these changes Jan 22, 2025
View reviewed changes
@AurelienFT AurelienFT enabled auto-merge (squash) January 22, 2025 23:47
@AurelienFT AurelienFT requested a review from xgreenx January 23, 2025 00:56
xgreenx
xgreenx approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified, it works

@AurelienFT AurelienFT merged commit d4b2b64 into master Jan 23, 2025
32 checks passed
@AurelienFT AurelienFT deleted the pin_netlink_proto_version branch January 23, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@MitchTurner MitchTurner MitchTurner approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

Assignees
No one assigned
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @MitchTurner @xgreenx