Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rocksdb): import when rocksdb is enabled within local_node_with_reader fn #2626

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix(rocksdb): import when rocksdb is enabled within local_node_with_reader fn #2626

merged 1 commit into from
Jan 24, 2025

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Jan 23, 2025

Linked Issues/PRs

reported by @hal3e

Description

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc self-assigned this Jan 23, 2025
@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Jan 23, 2025
@MitchTurner
Copy link
Member

MitchTurner commented Jan 23, 2025 •
edited
Loading

I guess I'm just surprised that use crate::state::rocks_db::DatabaseConfig; was available without the #[cfg(feature = "rocksdb")] enabled. I'd expect this to be caught by the compiler.

xgreenx
xgreenx approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to update CI to catch it in the future?

@AurelienFT AurelienFT merged commit d502afe into master Jan 24, 2025
43 of 45 checks passed
@AurelienFT AurelienFT deleted the fix/rocksdb-import branch January 24, 2025 09:41
@AurelienFT AurelienFT mentioned this pull request Jan 24, 2025
Merged
AurelienFT added a commit that referenced this pull request Jan 24, 2025
@AurelienFT
Release 0.41.3 (#2628)
56ebfab 
## Version 0.41.3

### Fixed
- [2626](#2626): Avoid needs
of RocksDB features in tests modules

## What's Changed

- fix(rocksdb): import when rocksdb is enabled within
local_node_with_reader fn by @rymnc in #2626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acerone85 acerone85 acerone85 approved these changes

@xgreenx xgreenx xgreenx approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees

@rymnc rymnc

Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rymnc @MitchTurner @xgreenx @acerone85 @AurelienFT