chore(gas_price_service): refactor usage of async_trait impls to improve performance #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
previously approved these changes
Jan 25, 2025
MitchTurner
reviewed
Jan 25, 2025
| @@ -203,7 +203,6 @@ mod tests { | |||
| l2_block: mpsc::Receiver<BlockInfo>, | |||
| } | |||
|
|
|||
| #[async_trait::async_trait] | |||
| impl L2BlockSource for FakeL2BlockSource { | |||
| async fn get_l2_block(&mut self) -> GasPriceResult<BlockInfo> { | |||
There was a problem hiding this comment.
Does the async still work here? I'm not sure if it desugars to the same.
There was a problem hiding this comment.
Yeah. I'm playing around with it in playground. Works for me.
MitchTurner
approved these changes
Jan 25, 2025
xgreenx
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
reduces heap allocs by removing usage of
async_traitfor small types being passed around in gas price service adapters. should improve performance because noPin<Box<Future>>>for small values which can be efficiently allocated on the stack instead.microbenchmarks yield performance increase of$$\approx 82.57\% %$$ for
get_l2_blockmakes
GasPriceProvidersyncbreaking:
consumers of the
L2BlockSourceandGasPriceProvidertraits, which is most likely just us at this pointChecklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]