chore(async_trait): reduce usage of async_trait for small types again #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
chore/remove-some-usage-of-async-trait
branch
3 times, most recently
from
a9d4adc to
3834ce9
Compare
rymnc
force-pushed
the
chore/remove-some-usage-of-async-trait
branch
from
3834ce9 to
0647db1
Compare
rymnc
requested review from
xgreenx,
Dentosal,
MitchTurner,
netrome and
acerone85
as code owners
rymnc
commented
Jan 26, 2025
| @@ -33,7 +33,8 @@ impl BlockImporterPort for PressureBlockImporter { | |||
| impl PressureBlockImporter { | |||
| pub fn new(counts: SharedCounts, delays: Duration) -> Self { | |||
| let mut mock = MockBlockImporterPort::default(); | |||
| mock.expect_execute_and_commit().returning(move |_| Ok(())); | |||
| mock.expect_execute_and_commit() | |||
| .returning(move |_| Box::pin(async move { Ok(()) })); | |||
xgreenx
approved these changes
Jan 26, 2025
acerone85
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
this pr description is AI generated, pls take with a grain of salt
This pull request includes several changes to remove asynchronous traits and methods, converting them to synchronous ones across various files. The most important changes include modifying the
GasPriceEstimatetrait and its implementations, updating test functions, and adjusting mock expectations.Conversion to Synchronous Methods:
crates/fuel-core/src/graphql_api/ports.rs: Removed theasync_traitattribute from theGasPriceEstimatetrait and changedworst_case_gas_priceto a synchronous method.crates/fuel-core/src/service/adapters.rs: Updated theGasPriceEstimateimplementations forUniversalGasPriceProviderandStaticGasPriceto synchronous methods. [1] [2]crates/services/gas_price_service/src/common/gas_price_algorithm.rs: Changed theupdateandworst_case_gas_pricemethods to synchronous. [1] [2]Updates to Test Functions:
crates/fuel-core/src/service/adapters.rs: Adjusted test functions to remove asynchronous calls and runtime blocks. [1] [2] [3]crates/services/sync/src/import/tests.rs: Updated mock expectations to return pinned async blocks for various test functions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Removal of
async_trait:crates/fuel-core/src/service/adapters/sync.rs: Removedasync_traitfromBlockImporterPortandConsensusPortimplementations. [1] [2]crates/services/sync/src/import/test_helpers/pressure_block_importer.rs: Removedasync_traitfromBlockImporterPortimplementation.crates/services/sync/src/import/test_helpers/pressure_consensus.rs: Removedasync_traitfromConsensusPortimplementation.These changes collectively simplify the codebase by removing unnecessary asynchronous complexity, making the code more straightforward and potentially improving performance.
Checklist