Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor make create contract helper function available outside of fuel core #2656

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

acerone85
Copy link
Contributor

Linked Issues/PRs

Closes #2654

Description

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

netrome
netrome previously approved these changes Jan 31, 2025
rymnc
rymnc previously approved these changes Feb 3, 2025
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rustfmt and toml lint i think, lgtm

@acerone85 acerone85 force-pushed the 2587-fault_provingglobal_roots-populate-contractsrawcode-table branch from ebe1f20 to 4177a75 Compare February 3, 2025 11:25
@acerone85 acerone85 force-pushed the 2654-refactor-make-create_contract-helper-function-available-outside-of-fuel-core branch from c992c98 to 1ea8e97 Compare February 3, 2025 15:28
@acerone85 acerone85 force-pushed the 2587-fault_provingglobal_roots-populate-contractsrawcode-table branch 3 times, most recently from e6aadd5 to 6bc31c6 Compare February 5, 2025 12:47
Base automatically changed from 2587-fault_provingglobal_roots-populate-contractsrawcode-table to master February 5, 2025 13:16
@netrome netrome dismissed rymnc’s stale review February 5, 2025 13:16

The base branch was changed.

@netrome netrome dismissed their stale review February 5, 2025 13:16

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants