Fix balances query endpoint cost without indexation and behavior coins to spend with one parameter at zero #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
xgreenx,
Dentosal,
MitchTurner,
netrome,
acerone85,
rafal-ch and
rymnc
as code owners
rymnc
previously approved these changes
Feb 3, 2025
Merged
netrome
previously approved these changes
Feb 3, 2025
Also wondering about this. |
MitchTurner
reviewed
Feb 3, 2025
MitchTurner
reviewed
Feb 3, 2025
MitchTurner
reviewed
Feb 3, 2025
Comment on lines
+100
to
+103
| #[graphql(complexity = "if query_costs().balance_query == 0 { \ | ||
| (child_complexity as f32 * first.unwrap_or_default() as f32 * 0.66) as usize + \ | ||
| (child_complexity as f32 * last.unwrap_or_default() as f32 * 0.66) as usize | ||
| ")] | ||
| } else { query_costs().balance_query }")] |
There was a problem hiding this comment.
I'd rather it be explicit:
if indexation_set {
query_costs().balance_query
} else {
...
}If that's not possible, let's leave a clear comment explaining the relationship between 0 and indexation.
MitchTurner
approved these changes
Feb 3, 2025
netrome
approved these changes
Feb 3, 2025
AurelienFT
added a commit
that referenced
this pull request
Feb 3, 2025
## Version 0.41.5 ### Changed - [2387](#2387): Update description `tx-max-depth` flag. - [2630](#2630): Removed some noisy `tracing::info!` logs - [2643](#2643): Before this fix when tip is zero, transactions that use 30M have the same priority as transactions with 1M gas. Now they are correctly ordered. ### Added - [2617](#2617): Add integration skeleton of parallel-executor. - [2553](#2553): Scaffold global merkle root storage crate. - [2598](#2598): Add initial test suite for global merkle root storage updates. - [2635](#2635): Add metrics to gas price service ### Fixed - [2632](#2632): Improved performance of certain async trait impls in the gas price service. - [2662](#2662): Fix balances query endpoint cost without indexation and behavior coins to spend with one parameter at zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two changes has been packed in one PR to speed up the release process given our deadlines.
The balance query endpoint cost if useful for the TSSDK team.
The coins to spend behaviour change roll back to the previous behavior, asked by Rust SDK team
Checklist
Before requesting review
After merging, notify other teams