Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notify_cancel): removed usage of async trait and made the trait dyn incompatible #2665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Feb 4, 2025

Linked Issues/PRs

  • none

Description

The code will bloat a little more, but that's fine :_) we don't have dyn dispatch for NotifyCancel anymore.

This pull request introduces changes to the fuel-core crate, primarily focusing on enhancing the flexibility and functionality of the TaskManager and CancellationToken structures. The changes include adding a generic parameter to these structures and updating related implementations to accommodate this new parameter.

Key changes include:

Enhancements to Task Management:

Updates to Genesis Exporter and Importer:

Modifications to Import Task:

Removal of Async Trait:

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Feb 4, 2025
@rymnc rymnc self-assigned this Feb 4, 2025
Base automatically changed from remove-async-trait-from-runnable-task to master February 4, 2025 15:54
@rymnc rymnc force-pushed the moar-async-traits branch from 6580b7e to dbc9c87 Compare February 4, 2025 16:40
@rymnc rymnc marked this pull request as ready for review February 4, 2025 16:40
@rymnc rymnc requested a review from a team February 4, 2025 16:40
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to get rid of some dynamic dispatch.

@rymnc rymnc enabled auto-merge (squash) February 5, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants