Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fault_proving(global_roots): Concrete error type for merkleized storage #2724

Merged
merged 4 commits into from
Feb 21, 2025
Merged

fault_proving(global_roots): Concrete error type for merkleized storage #2724

merged 4 commits into from
Feb 21, 2025
+156 −60

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Feb 18, 2025

closes #2588

@netrome netrome changed the title chore: Explicit error type for merkleized storage fault_proving(global_roots): Explicit error type for merkleized storage Feb 18, 2025
@netrome netrome force-pushed the 2588-fault_provingglobal_roots-proper-error-type branch from 4a06c24 to fc36725 Compare February 18, 2025 12:20
@netrome netrome changed the title fault_proving(global_roots): Explicit error type for merkleized storage fault_proving(global_roots): Concrete error type for merkleized storage Feb 18, 2025
@netrome netrome self-assigned this Feb 18, 2025
@netrome netrome force-pushed the 2707-fault_provingglobal_roots-service-definition-and-integration-tests branch from 41ccea0 to cfa53f3 Compare February 19, 2025 08:13
@netrome netrome force-pushed the 2588-fault_provingglobal_roots-proper-error-type branch from de9e62b to 870c09e Compare February 19, 2025 09:34
Base automatically changed from 2707-fault_provingglobal_roots-service-definition-and-integration-tests to master February 19, 2025 10:38
@netrome netrome force-pushed the 2588-fault_provingglobal_roots-proper-error-type branch 2 times, most recently from 3d9c3a1 to f8d9004 Compare February 20, 2025 08:12
@netrome netrome force-pushed the 2588-fault_provingglobal_roots-proper-error-type branch from f8d9004 to 4a3e513 Compare February 21, 2025 08:35
@netrome netrome marked this pull request as ready for review February 21, 2025 08:36
rymnc
rymnc previously approved these changes Feb 21, 2025
View reviewed changes
acerone85
acerone85 previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@acerone85 acerone85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits about adding more information in errors as they might be useful to debug if something ever goes wrong.

But this can be done in a follow up :)

@netrome netrome dismissed stale reviews from acerone85 and rymnc via d934c0d February 21, 2025 12:31
@netrome netrome requested review from acerone85 and rymnc February 21, 2025 12:32
@netrome netrome enabled auto-merge (squash) February 21, 2025 12:57
@netrome netrome disabled auto-merge February 21, 2025 13:28
@netrome netrome merged commit 35e4312 into master Feb 21, 2025
34 checks passed
@netrome netrome linked an issue Feb 21, 2025 that may be closed by this pull request
fault_proving(global_roots): Proper error type #2588
Closed
@netrome netrome deleted the 2588-fault_provingglobal_roots-proper-error-type branch February 21, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dentosal Dentosal Dentosal approved these changes

@acerone85 acerone85 acerone85 approved these changes

@rymnc rymnc rymnc approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

@rafal-ch rafal-ch Awaiting requested review from rafal-ch rafal-ch is a code owner

@AurelienFT AurelienFT Awaiting requested review from AurelienFT AurelienFT is a code owner

Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fault_proving(global_roots): Proper error type
4 participants
@netrome @Dentosal @acerone85 @rymnc