Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: learn more broken link #1389

Merged
merged 4 commits into from
Jul 2, 2024
Merged

fix: learn more broken link #1389

merged 4 commits into from
Jul 2, 2024

Conversation

Spiral-Memory
Copy link
Contributor

@Spiral-Memory Spiral-Memory commented Jun 24, 2024 •
edited
Loading

This PR fixes the issue of the "Learn More" link being shown while a connection request is being made. The problem of being unable to click "Learn More" properly was due to the overlapping of elements in the "Learn More" div and the button below it, to address it, i have removed -10px of margin. I have also added the homepage URL as an external link in "Learn More."

Kindly review the PR.

Attachments:

Screenshot from 2024-06-24 17-54-33

After suggested changes:

image

closes #1387

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Spiral-Memory Spiral-Memory force-pushed the fix/learn-more-link branch 2 times, most recently from e3c98a8 to 958c475 Compare June 29, 2024 05:39
@Spiral-Memory
Copy link
Contributor Author

Hey @LuizAsFight
Please review this PR as well !
Thanks

LuizAsFight
LuizAsFight requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Spiral-Memory thanks for your contribution, let's change it, can you just remove the link as it's not sending to anywhere useful for learning about the connection?
just remove the "Learn More" link and we're good

thanks !

@Spiral-Memory Spiral-Memory force-pushed the fix/learn-more-link branch from 958c475 to 4e89665 Compare July 2, 2024 05:13
@Spiral-Memory Spiral-Memory force-pushed the fix/learn-more-link branch from 4e89665 to 15aa4d3 Compare July 2, 2024 05:14
@Spiral-Memory
Copy link
Contributor Author

hi @Spiral-Memory thanks for your contribution, let's change it, can you just remove the link as it's not sending to anywhere useful for learning about the connection? just remove the "Learn More" link and we're good

thanks !

Hey @LuizAsFight ,

Sorry, I misunderstood the requirement earlier. I have made the changes accordingly and removed the "learn more" text. Please re-review this PR.

Thanks.

@Spiral-Memory Spiral-Memory requested a review from LuizAsFight July 2, 2024 05:30
@LuizAsFight LuizAsFight merged commit 2c60633 into FuelLabs:master Jul 2, 2024
11 of 12 checks passed
@LuizAsFight
Copy link
Contributor

thanks for the contribution @Spiral-Memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@arthurgeron arthurgeron Awaiting requested review from arthurgeron arthurgeron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Learn more link broken
3 participants
@Spiral-Memory @CLAassistant @LuizAsFight