Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: balance format precision with tooltips #1571

Merged
merged 20 commits into from
Oct 11, 2024
Merged

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Oct 9, 2024


I've also removed the balances from our browser storage. Let's keep it fetching directly from the node.

📷 Tiny Regular Huge
small amounts not so small huge amount

@helciofranco helciofranco self-assigned this Oct 9, 2024
@helciofranco helciofranco linked an issue Oct 9, 2024 that may be closed by this pull request
@helciofranco helciofranco marked this pull request as ready for review October 9, 2024 19:46
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is changing too much, the issue aims to fix the balance only, but I see the Approve Transaction screen is showing balance with <0.00001. Revert the changes in places we don't want and keep them only for showing correct balances.

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 problems here

  • its showing wrong balance for the unknown tokens, before it was with zero units and now it's using like 9 units
  • tooltip is showing only 0
image

@helciofranco
Copy link
Member Author

@LuizAsFight nice catch, fixes has been pushed.

@helciofranco helciofranco merged commit 112e002 into master Oct 11, 2024
15 checks passed
@helciofranco helciofranco deleted the hf/fix/eth-balance branch October 11, 2024 03:24
LuizAsFight pushed a commit that referenced this pull request Oct 11, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## @fuels/[email protected]



## [email protected]

### Minor Changes

- [#1572](#1572)
[`97185130`](9718513)
Thanks [@helciofranco](https://github.com/helciofranco)! - Reduce
transaction history loading time by optimizing the complexity of the
page info query.

- [#1571](#1571)
[`112e002c`](112e002)
Thanks [@helciofranco](https://github.com/helciofranco)! - Format tiny,
large, and regular amounts, applying 6 decimal places of precision.

### Patch Changes

- [#1570](#1570)
[`8e42400c`](8e42400)
Thanks [@nelitow](https://github.com/nelitow)! - Improve account name
colision verification

-   Updated dependencies \[]:
    -   @fuel-wallet/[email protected]

## @fuel-wallet/[email protected]

### Minor Changes

- [#1571](#1571)
[`112e002c`](112e002)
Thanks [@helciofranco](https://github.com/helciofranco)! - Format tiny,
large, and regular amounts, applying 6 decimal places of precision.

## @fuel-wallet/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not showing balance in asset cards of home Show balance with more precision
2 participants