Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contract info display for testnet contracts #1708

Closed
wants to merge 4 commits into from

Conversation

akintewe
Copy link

  • Add support for displaying contract names and logos in transaction approval screen
  • Support both mainnet and testnet (sepolia) contracts
  • Fetch contract info from fuel-ecosystem registry

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Dec 12, 2024

Thanks for the contribution! Before we can merge this, we need @akintewe to sign the Fuel Labs Contributor License Agreement.

@akintewe akintewe marked this pull request as draft December 12, 2024 21:47
@akintewe akintewe marked this pull request as ready for review December 13, 2024 07:51
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

this issue aims to have the UI version working , with the contract and name showing up on the approval screen, you plan to add that?

@akintewe
Copy link
Author

thanks for the contribution!

this issue aims to have the UI version working , with the contract and name showing up on the approval screen, you plan to add that?

yes i plan to add that

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some issues here:
1- its not showing correct, see prints this contract is detected on explorer but not in wallet
2- to test this you can connect to mainnet and interact directly with Fuel Bridge (you need to change in your .env the env
3- this needs to work on all transaction views, as they are all the same component this can be done in a reusable component instead of in TxApprove component. You can test by accessing Transaction History, by "Send Page" iunside the wallet and also asking for approval from external dapp
from

VITE_CRX_NAME="Fuel Wallet Development"

to

VITE_CRX_NAME="Fuel Wallet"
image image

@akintewe akintewe force-pushed the feat/contract-info-display branch from bf789ef to 61d5792 Compare December 15, 2024 17:52
@akintewe akintewe requested a review from LuizAsFight December 15, 2024 17:52
@akintewe
Copy link
Author

some issues here: 1- its not showing correct, see prints this contract is detected on explorer but not in wallet 2- to test this you can connect to mainnet and interact directly with Fuel Bridge (you need to change in your .env the env 3- this needs to work on all transaction views, as they are all the same component this can be done in a reusable component instead of in TxApprove component. You can test by accessing Transaction History, by "Send Page" iunside the wallet and also asking for approval from external dapp from

VITE_CRX_NAME="Fuel Wallet Development"

to

image image

Is there a faucet i can use to fund mainnet, because i was only able to test with testnet and its still showing unknown

@helciofranco
Copy link
Member

Closed by #1749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants