feat: add a quick way to authorize my current account #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helciofranco
requested review from
luizstacio,
LuizAsFight,
arthurgeron,
rodrigobranas and
nelitow
as code owners
LuizAsFight
reviewed
Jan 10, 2025
There was a problem hiding this comment.
this is an interesting idea but I think we would need design first to go for it, the topbar is looking a little bit crowded.
the idea of this issue is not exactly what is developed. this issue aims simply showing a toast or popup with a "connect" button so the user can connect his account from the wallet easily
|
@LuizAsFight reverting to draft. holding until we have a design. |
|
@helciofranco can we complete this PR fast using a simple popup like this? Was the initial intention |
arthurgeron
previously approved these changes
Jan 14, 2025
Co-authored-by: Arthur Geron <[email protected]>
LuizAsFight
approved these changes
Jan 18, 2025
LuizAsFight
pushed a commit
that referenced
this pull request
Jan 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @fuels/[email protected] ## [email protected] ### Minor Changes - [#1764](#1764) [`d81ee482`](d81ee48) Thanks [@helciofranco](https://github.com/helciofranco)! - Add current account connection status to the header - [#1762](#1762) [`2460beef`](2460bee) Thanks [@helciofranco](https://github.com/helciofranco)! - Add a separate NFTs tab to the home screen. - [#1710](#1710) [`4c530078`](4c53007) Thanks [@nelitow](https://github.com/nelitow)! - Improve handling of custom assets. ### Patch Changes - [#1778](#1778) [`6ddb0014`](6ddb001) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - fix: review button entering on loading state after getting ready to approve - [#1725](#1725) [`28628cbd`](28628cb) Thanks [@nelitow](https://github.com/nelitow)! - Allow editing network name when adding. - [#1778](#1778) [`6ddb0014`](6ddb001) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: remove intentional longer loading states to avoid blinking. - Updated dependencies \[]: - @fuel-wallet/[email protected] - @fuels/[email protected] ## @fuel-wallet/[email protected] ## @fuel-wallet/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FE-1174Screen.Recording.2025-01-14.at.16.42.15.mov