-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: configure spell-check #987
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 66.58% | 3381/5078 |
🔴 | Branches | 43.93% | 619/1409 |
🔴 | Functions | 50.21% | 713/1420 |
🟡 | Lines | 67.2% | 3260/4851 |
Test suite run success
241 tests passing in 73 suites.
Report generated by 🧪jest coverage report action from 297230e
This PR adds a spell-check to each docs workflow. You can see it tested here: Sway: FuelLabs/sway#5369 Fuelup: FuelLabs/fuelup#535 Specs: FuelLabs/fuel-specs#539 Fuels-rs: FuelLabs/fuels-rs#1224 Fuels-ts: FuelLabs/fuels-ts#1484 Wallet: FuelLabs/fuels-wallet#987 Indexer: FuelLabs/fuel-indexer#1496 GraphQL: FuelLabs/fuel-graphql-docs#25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work here !
@sarahschwartz can the list of words be in the CI itself inside of in this project ? then it can be easily reused across other projects
also maybe this PR can wait for other PRs as RN we have going the
after that will be ready to merge |
It can wait as long as you don't make any other changes to the docs, since the docs workflow is broken without this. And I thought about keeping the custom words list in one place, but I'm afraid that would slow down development since you would have to update 2 repos. Most tech terms need to be added to the list. |
We could have a default list and allow a per repo bases list also. In this way we would make the CI simpler, and if we need to customize it would be fast. |
That could work, I will follow up with another PR to do this later if that's ok. |
297230e
This PR configures the spell-check added to the docs workflow in the github-actions repo: FuelLabs/github-actions#23
The files checked are configured in
.spellcheck.yml
. This is also where you can configure what types of elements are ignored.Right now it ignores:
spell-check-custom-words.txt
(case sensitive, only exact match)Handling errors:
If the test fails:
spell-check-custom-words.txt
.lock
ing" and add "ing" to the custom words list. Instead, rewrite the sentence as "locking with thelock
method"..spellcheck.yml
.