Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Retrieving Nodes that support Mesh Capable Service #248

Conversation

sammychinedu2ky
Copy link
Contributor

Copy link
Contributor

@winstxnhdw winstxnhdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually review it but I think these should be filled up :D

Consul/Catalog.cs Outdated Show resolved Hide resolved
Consul/Catalog.cs Outdated Show resolved Hide resolved
Consul/Catalog.cs Outdated Show resolved Hide resolved
sammychinedu2ky and others added 3 commits October 19, 2023 11:20
Co-authored-by: Winston H. <[email protected]>
Co-authored-by: Winston H. <[email protected]>
Co-authored-by: Winston H. <[email protected]>
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sammychinedu2ky,

the implementation seems very reasonable, but I dislike that we cannot create mesh-capable services with our library. Without it, the test scenario is kind of artificial, because we are not testing whether the endpoint actually returns anything.
Would you want to investigate more on mesh-capable services and what changes we would need to be able to create them with our library?

@sammychinedu2ky
Copy link
Contributor Author

Hi @sammychinedu2ky,

the implementation seems very reasonable, but I dislike that we cannot create mesh-capable services with our library. Without it, the test scenario is kind of artificial, because we are not testing whether the endpoint actually returns anything. Would you want to investigate more on mesh-capable services and what changes we would need to be able to create them with our library?

Alright Chief

@sammychinedu2ky
Copy link
Contributor Author

sammychinedu2ky commented Oct 27, 2023

The mesh service focuses more on Kubernetes support, which the test environment doesn't create. We would need to create a running Consul server with Consul service mesh enabled

@sammychinedu2ky
Copy link
Contributor Author

Resolved by #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants