-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for Retrieving Nodes that support Mesh Capable Service #248
Added Support for Retrieving Nodes that support Mesh Capable Service #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't actually review it but I think these should be filled up :D
Co-authored-by: Winston H. <[email protected]>
Co-authored-by: Winston H. <[email protected]>
Co-authored-by: Winston H. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sammychinedu2ky,
the implementation seems very reasonable, but I dislike that we cannot create mesh-capable services with our library. Without it, the test scenario is kind of artificial, because we are not testing whether the endpoint actually returns anything.
Would you want to investigate more on mesh-capable services and what changes we would need to be able to create them with our library?
Alright Chief |
The mesh service focuses more on Kubernetes support, which the test environment doesn't create. We would need to create a running Consul server with Consul service mesh enabled |
Resolved by #273 |
This pull request adds support for this
https://developer.hashicorp.com/consul/api-docs/catalog#list-nodes-for-mesh-capable-service