-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend CI/CD 파이프라인 설정 #11 #12
Conversation
docker-compose.dev.yaml
Outdated
image: redis:latest | ||
container_name: redis | ||
hostname: redis | ||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 되면, 서버의 6379 포트로 레디스 접근이 가능해요!
8080만 열어두고, 6379는 내부망을 이용해서 외부 포트는 감추는 게 좋을 거 같아요
관련 내용은 도커 네트워크 찾아보시면 바로 적용할 수 있을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expose 키워드가 있던데 ports 대신 해당 키워드 사용하면 될까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로 pull request발생 시 수행하는 github action test yaml과 CD yaml은 분리하는게 어떨까 생각합니다.
또한
- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
if: always()
with:
junit_files: '**/build/test-results/test/TEST-*.xml'
이런 코드를 사용하면 테스트 리포트도 생성할 수 있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
close #11
구현 기능
추가 사항