Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yujeongkwon #7

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

yujeongkwon
Copy link

No description provided.

Copy link

@nuyh99 nuyh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고네요

@@ -0,0 +1,27 @@
## 입/출력
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하시네요!

public class Cash implements Payment{
private int cashInput = 0;

public void injectionCash(int inputOption) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메서드 명은 동사로 하면 좋을 것 같아요!

import java.util.Arrays;

public class Cash implements Payment{
private int cashInput = 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI와 도메인이 커플링이 커보이는데 괜찮을까요?!

Comment on lines +13 to +21
public static int readBeverageOption(Scanner scanner) {
System.out.print("사용자 입력 >");
return scanner.nextInt();
}

public static int readBeverageNumber(Scanner scanner) {
System.out.print("사용자 입력 >");
return scanner.nextInt();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

분리했을 때 장단점이 어떻게 될까요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants