Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cycleNumber field from CycleData0 through CycleData4 #21

Merged
merged 2 commits into from
Oct 31, 2016

Conversation

0xbarrett
Copy link
Contributor

As @Hixie identified in #9, the cycleNumber field in dishwasher.cycleData0 through dishwasher.cycleData4 is giving unexpected results. It turns out that this field does not exist in the ERD data coming from the dishwasher.

* Also specify that all cycle data is read-only
@Hixie
Copy link

Hixie commented Oct 31, 2016

I'm skeptical about this patch. The data I get for all the fields after cycleNumber is self-consistent. For example, the cycle duration goes up by one minute every minute. The temperatures are exactly in the expected range, and go up at expected times in the cycle.

Is it possible that the cycleTime is just 16 bits? That would explain why very occasionally I see a cycleNumber 1 with a duration 0, that would be a 4h 16m program. That would be consistent with those always happening when I'm doing a Heavy, Steam, Heated Dry cycle.

@0xbarrett
Copy link
Contributor Author

Good catch. I just checked the code and it turns out that the cycleDuration is 16-bits instead of 8. The cycle time is still 32-bits. But you're right, that explains why the cycleNumber would be 1 for cycles that exceed 255 minutes.

@Hixie
Copy link

Hixie commented Oct 31, 2016

Er, right, I meant cycleDuration.

@Hixie
Copy link

Hixie commented Oct 31, 2016

LGTM, for whatever that's worth. :-)

@0xbarrett
Copy link
Contributor Author

/cc: @bakerface

@bakerface bakerface merged commit 5e8c89d into GEMakers:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants