XML string array errors feedback #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
9 tasks
MelReyCG
requested review from
TotoGaz,
corbett5,
rrsettgast and
jeannepellerin
untereiner
approved these changes
Mar 31, 2023
| string rp = "[^*?<>\\|:\";,\\s]+\\s*";//"[^*?\\<\\>\\|:\\",\\s]+\\s*"; | ||
|
|
||
| // Regex to match a path: a string that does not contain any space nor the characters *?<>|:", | ||
| string rpe = "[^*?<>\\|:\";,\\s]*\\s*";//"[^*\\?<\\>\\|:\\",\\s]*\\s*"; |
There was a problem hiding this comment.
could be static constexpr auto instead of string ?
There was a problem hiding this comment.
I'm afraid we cannot because of r1 and r2s need string operations. We would need string_view here.
cssherman
approved these changes
May 15, 2023
TotoGaz
approved these changes
May 18, 2023
There was a problem hiding this comment.
Great, thx @MelReyCG
@cssherman Do you think there are any implications with those regex in our global process (python validation or anything else)?
| string rs = "[^,\\{\\}]*"; | ||
| // Regex to match a string that can't be empty and does not contain any whitespaces nor the characters ,{} | ||
| // TODO c++17: Move to static constexpr std::string_view | ||
| string rs = "[^,\\{\\}\\s]+\\s*"; |
There was a problem hiding this comment.
Do you need to take action with potential initial spaces (like toto) or is it OK?
There was a problem hiding this comment.
This pattern will be permissive of spaces at the end of the string, but not at the beginning, which should be fine, right?
"hello": match
"hello world": no match
"hello, world": no match
" hello": no match
"hello ": match
rrsettgast
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the error messages from XML string array in a more user-friendly way:
LvArray::input::stringToArray()is needed (LvArray PR #280),This PR solves the case 1 of issue #2320.
LvArray PR #280