Solve reappearing compilation issue on PPC machines with NVCC due to FMT bug #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TotoGaz
approved these changes
Oct 16, 2023
paveltomin
approved these changes
Oct 16, 2023
sframba
added
flag: ready for review
ci: run CUDA builds
tbeltzun
changed the title
pradhyumna85
pushed a commit
to pradhyumna85/GEOS
that referenced
this pull request
Nov 2, 2023
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 2701 has appeared again, this time due to changes made in PR 2756.
The problem is still due to an unresolved bug in the FMT library. This time, it's the
array1d< int >class that is not recognized as formattable by FMT. The same workaround applies.Since now the FMT issue involves multiple objects, the original workaround is moved to the
Format.hppfile, and the specialization toDataContextis removed. It is still only enabled by a specific flag in the host config file, which is disabled by default.Hopefully, it will be possible to remove this workaround with some future update of the FMT library.
The fix is a sequel to PR #2702.