Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print Hypre preconditioner setup error #2935

Merged
merged 22 commits into from
Feb 3, 2024
Merged

Print Hypre preconditioner setup error #2935

merged 22 commits into from
Feb 3, 2024

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Jan 15, 2024 •
edited
Loading

need to go after #2928

@paveltomin paveltomin requested a review from victorapm January 15, 2024 21:11
@paveltomin paveltomin self-assigned this Jan 15, 2024
@paveltomin paveltomin mentioned this pull request Jan 15, 2024
Closed
@paveltomin paveltomin marked this pull request as ready for review January 16, 2024 23:56
@paveltomin paveltomin linked an issue Jan 17, 2024 that may be closed by this pull request
Bad linear solver performance when switching oil and water order in SPE10 #2672
Closed
victorapm
victorapm approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@victorapm victorapm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jan 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c33208f) 51.39% compared to head (f856e19) 51.39%.
Report is 2 commits behind head on develop.

❗ Current head f856e19 differs from pull request most recent head d097442. Consider uploading reports for the commit d097442 to get more accurate results

Files Patch % Lines
...arAlgebra/interfaces/hypre/HyprePreconditioner.cpp 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2935      +/-   ##
===========================================
- Coverage    51.39%   51.39%   -0.01%     
===========================================
  Files          972      972              
  Lines        86993    86999       +6     
===========================================
+ Hits         44711    44713       +2     
- Misses       42282    42286       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: no rebaseline Does not require rebaseline and removed flag: ready for review labels Feb 2, 2024
@paveltomin paveltomin merged commit ee9cc98 into develop Feb 3, 2024
20 of 21 checks passed
@paveltomin paveltomin deleted the pt/hypre-print-error branch February 3, 2024 16:08
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
@paveltomin @castelletto1 @ouassimkh
Print Hypre preconditioner setup error (#2935)
0286d60 
Co-authored-by: Pavel Tomin <“[email protected]”>
Co-authored-by: Nicola Castelletto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castelletto1 castelletto1 castelletto1 approved these changes

@victorapm victorapm victorapm approved these changes

Assignees

@paveltomin paveltomin

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad linear solver performance when switching oil and water order in SPE10
3 participants
@paveltomin @castelletto1 @victorapm