Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Preparatory for well to frac connection #3227

Merged
merged 68 commits into from
Feb 6, 2025
Merged

refactor: Preparatory for well to frac connection #3227

merged 68 commits into from
Feb 6, 2025

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Jul 17, 2024 •
edited
Loading

This PR includes preparatory changes for supporting well to frac connections.

  • replace CellElementSubRegion with ElementSubRegionBase where possible
  • where not possible - use templates
  • introduce targetRegion for perforations, to be able to connect to matrix or fracture (if targetRegion is not specified that means perforation will try to connect to all regions)
  • adjust connectPerforationsToMeshElements logic - since target region is already defined, loop through subregions in searchLocalElements, also adjust visitNeighborElements and initializeLocalSearch

@paveltomin paveltomin changed the base branch from develop to pt/seq-wells-frac September 13, 2024 21:45
@paveltomin paveltomin changed the title well to frac (draft) refactor: Preparatory for well to frac Sep 14, 2024
@paveltomin paveltomin changed the title refactor: Preparatory for well to frac refactor: Preparatory for well to frac connection Sep 14, 2024
@paveltomin paveltomin requested a review from tjb-ltk September 16, 2024 16:34
@paveltomin paveltomin marked this pull request as ready for review September 16, 2024 16:34
@paveltomin paveltomin removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jan 16, 2025
@paveltomin paveltomin removed the request for review from corbett5 January 23, 2025 22:44
@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs and removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run code coverage enables running of the code coverage CI jobs labels Feb 1, 2025
@paveltomin paveltomin added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Feb 1, 2025
@paveltomin paveltomin added the type: feature New feature or request label Feb 1, 2025
@paveltomin paveltomin added the ci: run code coverage enables running of the code coverage CI jobs label Feb 6, 2025
@paveltomin paveltomin merged commit 3cddb9f into develop Feb 6, 2025
26 of 27 checks passed
@paveltomin paveltomin deleted the pt/well-frac branch February 6, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelReyCG MelReyCG MelReyCG left review comments

@tjb-ltk tjb-ltk tjb-ltk left review comments

@CusiniM CusiniM CusiniM approved these changes

@Guotong-Ren Guotong-Ren Guotong-Ren approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@untereiner untereiner Awaiting requested review from untereiner untereiner is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@ryar9534 ryar9534 Awaiting requested review from ryar9534 ryar9534 is a code owner

Assignees

@paveltomin paveltomin

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: cleanup / refactor Non-functional change (NFC) type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paveltomin @CusiniM @MelReyCG @Guotong-Ren @tjb-ltk