feat: well time step selector based on rates/bhp tables and clarify well rates logic #3427
+467
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
requested review from
CusiniM,
castelletto1,
rrsettgast,
klevzoff,
francoishamon,
matteofrigo5,
cssherman and
wrtobin
as code owners
paveltomin
commented
Nov 6, 2024
| @@ -377,4 +377,73 @@ WellControls const & WellSolverBase::getWellControls( WellElementSubRegion const | |||
| return this->getGroup< WellControls >( subRegion.getWellControlsName()); | |||
| } | |||
|
|
|||
| real64 WellSolverBase::setNextDt( real64 const & currentTime, const real64 & lastDt, geos::DomainPartition & domain ) | |||
There was a problem hiding this comment.
main thing is in this function
paveltomin
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
paveltomin
commented
Nov 8, 2024
Guotong-Ren
approved these changes
Nov 19, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
@CusiniM, @VidarStiernstrom, @castelletto1, @cssherman, @frankfeifan, @jhuang2601, @matteofrigo5, @rrsettgast, @ryar9534, and/or @wrtobin please review |
paveltomin
added
the
ci: run integrated tests
paveltomin
requested review from
untereiner,
corbett5 and
MelReyCG
as code owners
paveltomin
added
the
flag: requires rebaseline
added 2 commits
December 4, 2024 13:19
paveltomin
removed
the
ci: run integrated tests
|
@CusiniM, @VidarStiernstrom, @castelletto1, @cssherman, @frankfeifan, @jhuang2601, @matteofrigo5, @rrsettgast, @ryar9534, @wrtobin please review |
|
@CusiniM, @VidarStiernstrom, @castelletto1, @cssherman, @frankfeifan, @jhuang2601, @matteofrigo5, @rrsettgast, @ryar9534, @wrtobin need review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things in this PR:
setNextDtin well solver which looks at all rates/bhp/status tables and makes sure time step is selected so that we honor table intervals. Can be enabled bytimeStepFromTablesflag in well solver.t_n+dt(end of time step) - switch tot_n(beginning of time step) - this should be more consistent withlowerinterpolation method that is used and prevent grabbing "future" rate from tables and avoid weird behavior when time step cut can lead to shutting of wells.