fix: Add source value array for fwi in wave solvers #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acitrain
added
ci: run CUDA builds
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3502 +/- ##
===========================================
+ Coverage 56.74% 56.75% +0.01%
===========================================
Files 1169 1169
Lines 101546 101582 +36
===========================================
+ Hits 57621 57653 +32
- Misses 43925 43929 +4 ☔ View full report in Codecov by Sentry. |
acitrain
added
the
ci: run integrated tests
sframba
approved these changes
Jan 29, 2025
sframba
approved these changes
Jan 29, 2025
| @@ -222,18 +222,10 @@ | |||
| </xsd:unique> | |||
| </xsd:element> | |||
| <xsd:element name="Functions" type="FunctionsType" maxOccurs="1"> | |||
| <xsd:unique name="FunctionsCompositeFunctionUniqueName"> | |||
There was a problem hiding this comment.
There seem to be some spurious changes in the schema.xsd and schema.xsd.other file. Maybe you used an out-of-date version? Try regenerating after merging the latest develop branch, it should fix the issue
rrsettgast
approved these changes
Jan 30, 2025
Comment on lines
259
to
262
| //real64 const srcValue = | ||
| // useSourceWaveletTables ? sourceWaveletTableWrappers[ isrc ].compute( &time_n ) : WaveSolverUtils::evaluateRicker( time_n, | ||
| // timeSourceFrequency, timeSourceDelay, rickerOrder ); | ||
|
|
There was a problem hiding this comment.
Suggested change
| //real64 const srcValue = | |
| // useSourceWaveletTables ? sourceWaveletTableWrappers[ isrc ].compute( &time_n ) : WaveSolverUtils::evaluateRicker( time_n, | |
| // timeSourceFrequency, timeSourceDelay, rickerOrder ); |
| for( localIndex inode = 0; inode < sourceConstants.size( 1 ); ++inode ) | ||
| { | ||
| real32 const localIncrement = sourceConstants[isrc][inode] * srcValue; | ||
| real32 const localIncrement = sourceConstants[isrc][inode] * sourceValue[cycleNumber][isrc]; | ||
| //real32 const localIncrement = sourceConstants[isrc][inode] * srcValue; |
There was a problem hiding this comment.
Suggested change
| //real32 const localIncrement = sourceConstants[isrc][inode] * srcValue; |
| MeshLevel & mesh, | ||
| arrayView1d< string const > const & regionNames ) | ||
| { | ||
| MeshLevel & baseMesh = domain.getMeshBodies().getGroup< MeshBody >( meshBodyName ).getBaseDiscretization(); | ||
| precomputeSourceAndReceiverTerm( baseMesh, mesh, regionNames ); | ||
|
|
There was a problem hiding this comment.
Suggested change
| GEOS_UNUSED_VAR( meshBodyName ); |
| @@ -252,12 +288,10 @@ void AcousticWaveEquationSEM::initializePostInitialConditionsPreSubGroups() | |||
|
|
|||
|
|
|||
|
|
|||
| forDiscretizationOnMeshTargets( domain.getMeshBodies(), [&] ( string const & meshBodyName, | |||
| forDiscretizationOnMeshTargets( domain.getMeshBodies(), [&] ( string const &, | |||
There was a problem hiding this comment.
Suggested change
| forDiscretizationOnMeshTargets( domain.getMeshBodies(), [&] ( string const &, | |
| forDiscretizationOnMeshTargets( domain.getMeshBodies(), [&] ( string const & meshBodyName, |
| setInputFlag( InputFlags::FALSE ). | ||
| setRestartFlags( RestartFlags::NO_WRITE ). | ||
| setSizedFromParent( 0 ). | ||
| setDescription( "Source Value of the sources" ); |
acitrain
requested review from
cssherman,
castelletto1,
jhuang2601 and
paveltomin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding an array to store the values of the sources in time.
This array is useful for FWI and pygeos