Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move contact into solidMechanics #3531

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

paveltomin
Copy link
Contributor

No description provided.

@paveltomin paveltomin added type: cleanup / refactor Non-functional change (NFC) ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 29, 2025
@paveltomin paveltomin self-assigned this Jan 29, 2025
@paveltomin paveltomin added the flag: no rebaseline Does not require rebaseline label Jan 29, 2025
@paveltomin paveltomin removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jan 30, 2025
Copy link
Member

@rrsettgast rrsettgast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paveltomin I don't see any changes that aren't just path corrections and scope corrections. Is this accurate?

@paveltomin
Copy link
Contributor Author

@paveltomin I don't see any changes that aren't just path corrections and scope corrections. Is this accurate?

yes correct

@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run code coverage enables running of the code coverage CI jobs labels Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 56.74%. Comparing base (bd70903) to head (aa6154a).

Files with missing lines Patch % Lines
...ntact/SolidMechanicsAugmentedLagrangianContact.cpp 0.00% 17 Missing ⚠️
...ontact/SolidMechanicsLagrangeContactBubbleStab.cpp 0.00% 14 Missing ⚠️
...lvers/solidMechanics/contact/ContactSolverBase.cpp 0.00% 13 Missing ⚠️
...sics/SinglePhasePoromechanicsEmbeddedFractures.cpp 0.00% 10 Missing ⚠️
...hanics/contact/SolidMechanicsEmbeddedFractures.cpp 0.00% 7 Missing ⚠️
...ics/MultiphasePoromechanicsConformingFractures.cpp 0.00% 6 Missing ⚠️
...cs/SinglePhasePoromechanicsConformingFractures.cpp 0.00% 6 Missing ⚠️
.../physicsSolvers/inducedSeismicity/SpringSlider.cpp 0.00% 5 Missing ⚠️
...echanics/contact/SolidMechanicsLagrangeContact.cpp 0.00% 3 Missing ⚠️
...omponents/constitutive/contact/CoulombFriction.hpp 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3531   +/-   ##
========================================
  Coverage    56.74%   56.74%           
========================================
  Files         1169     1169           
  Lines       101546   101546           
========================================
  Hits         57621    57621           
  Misses       43925    43925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants