-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move contact into solidMechanics #3531
Open
paveltomin
wants to merge
4
commits into
develop
Choose a base branch
from
pt/move-contact
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
added
type: cleanup / refactor
Non-functional change (NFC)
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
flag: ready for review
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
labels
Jan 29, 2025
paveltomin
requested review from
rrsettgast,
CusiniM,
castelletto1,
jhuang2601,
frankfeifan,
ryar9534,
matteofrigo5,
VidarStiernstrom and
Guotong-Ren
as code owners
January 29, 2025 20:28
rrsettgast
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paveltomin I don't see any changes that aren't just path corrections and scope corrections. Is this accurate?
yes correct |
rrsettgast
added
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run code coverage
enables running of the code coverage CI jobs
labels
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run code coverage
enables running of the code coverage CI jobs
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: no rebaseline
Does not require rebaseline
flag: ready for review
type: cleanup / refactor
Non-functional change (NFC)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.