Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove SolidMechanicsLagrangianSSLE and rename SolidMechanics_LagrangianFEM to SolidMechanicsLagrangianFEM #3533

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: remove SolidMechanicsLagrangianSSLE and rename SolidMechanics_LagrangianFEM to SolidMechanicsLagrangianFEM #3533

wants to merge 1 commit into from

Conversation

paveltomin
Copy link
Contributor

No description provided.

refactor: remove SolidMechanicsLagrangianSSLE and rename SolidMechani…
576a743 
…cs_LagrangianFEM to SolidMechanicsLagrangianFEM
@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 31, 2025
@paveltomin paveltomin self-assigned this Jan 31, 2025
@paveltomin paveltomin added flag: ready for review type: cleanup / refactor Non-functional change (NFC) flag: no rebaseline Does not require rebaseline labels Jan 31, 2025
@rrsettgast
Copy link
Member

@paveltomin once this passes all tests and @CusiniM approves this, I don't think this requires further review. Put it in the queue and I will bypass code owner review to merge this.

jhuang2601
jhuang2601 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, we can get rid of the confusion on mechanical solver name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@castelletto1 castelletto1 castelletto1 approved these changes

@rrsettgast rrsettgast rrsettgast approved these changes

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@ryar9534 ryar9534 Awaiting requested review from ryar9534 ryar9534 is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

@VidarStiernstrom VidarStiernstrom Awaiting requested review from VidarStiernstrom VidarStiernstrom is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@paveltomin paveltomin

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paveltomin @rrsettgast @castelletto1 @jhuang2601