-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum Fortran versions #191
base: develop
Are you sure you want to change the base?
Conversation
@LiamBindle A query. Do you use any compilers older that what are proposed here. |
Yes for GCC. We frequently use GCC 8.3. What version of MAPL would this new requirement be introduced? It's understandable that these things are necessary every once in a while, and GCC 10 has been out for some time now. As long as it truely is a necessary upgrade, it's okay on our end. I can post in our documentation that GCC 8.3 support is deprecated and will be removed in a future version of GCHP (when we upgrade to this version of MAPL). For Intel our minimum is also 18.0.5, and we haven't ever supported NAG. |
@LiamBindle Interesting. If you can run with GCC 8 then maybe that means even GFE can? I now invoke the name of @tclune to see if he thinks some of his upcoming GFE code will work with GCC 8. If it can, well, we can not up the minimum version of GCC. If not, then we can up the requirement when new GFE starts being used in MAPL. I guess I figure "No one uses GCC 8. It's old!" 😄 Though I suppose GNU would prefer users use GCC 8.5... |
Well, yafyaml is passing the unit tests with 9.4. I'll try soon with 8.3 |
Wow - gfortran 8.5 also passes the unit tests for yafyaml! I'm surprised given all the difficulties I had getting things to work with Intel and NAG. |
8.5 is pretty new so maybe they backported all the bug fixes back to it?? |
On certain other projects, I have experienced that GCC 9.2 fails at compile time due to its bugs (later 9.x releases work). Hopefully they don't impact your project--I just use other versions like GCC 8.5 or 9.x > 9.2 etc. |
Ooh. I'd forgotten about this PR. I should review it. Frankly, we know our code is not happy even with anything less than GCC 10+. Maaaaaybe 9.5 would work? But we have enough fancy Fortran in MAPL that we probably need to be at 10.3 or so and higher. |
Given recent events in MAPL and GOCART, I'm proposing increasing the minimum compilers supported by ESMA_cmake to: