Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates for integration of ldasGC into adas #275

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

updates for integration of ldasGC into adas #275

wants to merge 6 commits into from

Conversation

saraqzhang
Copy link
Contributor

the modifications/addition are done to the base tag: adas v5.30.2

@saraqzhang saraqzhang added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Apr 11, 2024
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@github-actions GitHub Actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: Contingent - DNA

1 similar comment
@github-actions GitHub Actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: Contingent - DNA

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA

@gmao-rreichle gmao-rreichle added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Apr 12, 2024
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@saraqzhang saraqzhang mentioned this pull request Apr 23, 2024
Closed
@saraqzhang
Copy link
Contributor Author

@rtodling @gmao-rreichle I closed PR#265 , the updates for ladasGC so far are all in PR#275 here.

@saraqzhang saraqzhang removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Apr 25, 2024
@saraqzhang saraqzhang marked this pull request as ready for review April 25, 2024 19:21
@saraqzhang saraqzhang requested review from a team as code owners April 25, 2024 19:21
rtodling
rtodling previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem pretty inoffensive to the Atmos DAS.

@rtodling
Copy link
Collaborator

rtodling commented Jun 5, 2024

It would be helpful to explicitly list the other PRs (other repos) this PR is contingent on.

@saraqzhang
Copy link
Contributor Author

saraqzhang commented Jun 5, 2024 •
edited by rtodling
Loading

@rtodling this PR is not contingent on other currently outstanding PRs, assuming that gcmGC version is already updated in adas develop.

Sorry - I misread ... you actually removed the contingency - thank you -- sorry

rtodling added a commit that referenced this pull request Jul 8, 2024
@rtodling
somewhat forced merge of PR #275 into 5.30+jedi
e280da5
@gmao-rreichle
Merge branch 'develop' into feature/saraqzhang/ADASldasGC_GEOSadas-5.…
d2e6999 
…30.2; manually resolved conflicts (components.yaml, x3dvar_ladas.input); fixed typo in comment
@gmao-rreichle
Copy link
Contributor

@rtodling: We updated the branch of this PR to develop, and it's now obsolete. In doing so, we noticed a typo. If you want, go ahead and merge the PR to fix the typo, or just close it an live with the typo. Up to you.

@mathomp4 mathomp4 requested a review from rtodling November 15, 2024 13:58
mathomp4
mathomp4 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Cmake.

ETA: Huh. Actually, I wonder why CMake Team was needed here. GitHub be weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@rtodling rtodling Awaiting requested review from rtodling

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saraqzhang @rtodling @gmao-rreichle @mathomp4