Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify twindow.rc, twindow_m2.rc to add (excluded) newer wind types #288

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gmao-msienkie
Copy link
Contributor

Some new wind types (NC005072, NC005081) that are not used.
This will avoid messages in the output about these unknown wind types.
There should be no difference in the output.

@gmao-msienkie gmao-msienkie requested a review from a team as a code owner October 15, 2024 18:27
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@gmao-msienkie gmao-msienkie added 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Oct 15, 2024
@gmao-msienkie
Copy link
Contributor Author

Tests with the modified rc files gave identical results in BUFR output. These messages no longer printed:
twindow: error, NC005081 not found in subset table
twindow: error, NC005072 not found in subset table

@rtodling rtodling changed the base branch from develop to R21C November 5, 2024 16:36
@rtodling rtodling requested a review from a team as a code owner November 5, 2024 16:36
@rtodling rtodling changed the base branch from R21C to develop November 5, 2024 16:37
@rtodling
Copy link
Collaborator

rtodling commented Nov 5, 2024

@gmao-msienkie I believe these changes are mainly aimed at R21C (M21C), am I correct? It seems they would be ok going into develop - but these would need to be brought in to R21C. Can you confirm, pls?

@gmao-msienkie
Copy link
Contributor Author

These changes are actually only relevant for the older systems like MERRA2 and FPIT. It is run as a data preprocessing step in operations. We wanted to limit the amount of wind data read in to avoid overflow of the internal array, and to keep the amount of AMVs assimilated similar to what had been using.
We do have this code in Github however, inherited from the older CVS repository.
Someone else will need to take on maintenance of this code since it seems like there is interest in keeping MERRA2 going for longer than I anticipated. It is possible it may need to be modified for other changes in the AMVs before MERRA2 is finally retired.
R21C and modern systems do not need this although there will still need to be a process of updating R21C when changes occur to the AMV input - which I will happily leave to those who will be maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants