Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R21C: Additional change related to python3 stuff #313

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

rtodling
Copy link
Collaborator

All seems to work for AOD analysis on Milan (wrt python 3 updates).

These are not guarantee to be zero diff though I have seen cases in which the changes are zero diff.

@rtodling rtodling added the Non 0-diff The changes in this pull request are non-zero-diff label Nov 29, 2024
@rtodling rtodling requested a review from mathomp4 November 29, 2024 17:50
@rtodling
Copy link
Collaborator Author

Need final official tag on MAPL to be able to turn this from draft to actual PR.

mathomp4
mathomp4 previously approved these changes Nov 29, 2024
@rtodling
Copy link
Collaborator Author

@mathomp4 do you please to tag MAPL from

release/2.35.3+R21C_v1.4.0 to

v2.35.3+R21C_v1.4.0

?

@mathomp4
Copy link
Member

@mathomp4 do you please to tag MAPL from

release/2.35.3+R21C_v1.4.0 to

v2.35.3+R21C_v1.4.0

?

@rtodling It should be there now:

https://github.com/GEOS-ESM/MAPL/releases/tag/v2.35.3%2BR21C_v1.4.0

@rtodling
Copy link
Collaborator Author

@mathomp4 do you please to tag MAPL from
release/2.35.3+R21C_v1.4.0 to
v2.35.3+R21C_v1.4.0
?

@rtodling It should be there now:

https://github.com/GEOS-ESM/MAPL/releases/tag/v2.35.3%2BR21C_v1.4.0

Thank you!

@rtodling rtodling marked this pull request as ready for review November 29, 2024 18:00
@rtodling rtodling requested a review from a team as a code owner November 29, 2024 18:00
@rtodling rtodling changed the title Additional change related to python3 stuff R21C: Additional change related to python3 stuff Nov 29, 2024
@rtodling
Copy link
Collaborator Author

@mathomp4 All seems to have completed here, but still not letting me finish the PR. Can you please have a look? Sorry.

@rtodling
Copy link
Collaborator Author

Perhaps it needs a reviewer ... if you could pls.

@mathomp4 mathomp4 self-requested a review November 29, 2024 18:51
@rtodling
Copy link
Collaborator Author

Thank you!

@rtodling rtodling merged commit f738da9 into R21C Nov 29, 2024
6 checks passed
@mathomp4
Copy link
Member

Perhaps it needs a reviewer ... if you could pls.

Yeah. I guess an update staled my review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants