-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gaas fix for amip emissions #282
Conversation
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix |
1 similar comment
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix |
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix |
Just a note: this file will need to be updated if the offset is no longer 450s (a match of the heartbeat_dt in cap.rc). @bena-nasa has open a ticket to have a more flexible solution in ExtData. |
Ooh. Yeah. In GEOSgcm v12 this can really not be true. The heartbeat is resolution dependent from like 1800 s to 225 or so. |
When we get to that point, I would recommend we use a token like HEARTBEAT in the yaml file that gets replaced by the run script. |
Do we really want fail_on_missing_file to be FALSE by default? Won't this lead to confusion if the file path is wrong, but the user assumes that all is working properly? What would be the down-side of fail_on_missing_file = TRUE? |
I think @bena-nasa knows why that is there...and I think it needs to be? |
@mmanyin with regards to the |
@bena-nasa Thanks for the clarifications. I will go ahead and approve the PR, with the big caveat to set fail_on_missing_file to TRUE if the model is running in non-forecast mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a step in the right direction. It depends on the proper assignment of REPLAY_ANA_EXPID and REPLAY_ANA_LOCATION in AGCM.rc, and some clever code in the run script, but it works. Two caveats, as mentioned in the discussion: PT450S will need to be changed if the timestep changes. And the 'fail_on_missing_file' flag for each export should probably be set to TRUE for hindcast simulations, to help guard against inadvertent mistakes.
When the model runs in replay with GAAS turned on and AMIP emissions chosen, the model crashes after several days with a segmentation fault. AOD becoming completely off.
This PR updates the GAAS_GridComp_Extdata.yaml in AMIP/ similar to the one in OPS.
Fixes #281