Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CTM to be in line with GEOSgcm 10.19.5 #41

Closed
wants to merge 6 commits into from

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Dec 6, 2021

Since #39 was just merged, I figured it's time to get in line with 10.19.5. This should be zero-diff, but I'll let @mmanyin test.

Mainly components and scripting, but there is one bit that might look interesting. I removed all the CVS bits from ctm_setup since, well, they were useless in Git land and added the new bits for the source tarfile. For more information see:

GEOS-ESM/GEOSgcm#342

There is a chunk of text added to the README.md about this:

Create and install source tarfile

Note that running with parallel_build.csh will create and install a tarfile of the source code at build time. But if CMake is run by hand, this is not the default action (as many who build with CMake by hand are developers and not often running experiments). In order to enable this at install time, add:

-DINSTALL_SOURCE_TARFILE=ON

to your CMake command.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 6, 2021
@mathomp4 mathomp4 self-assigned this Dec 6, 2021
@mathomp4 mathomp4 requested review from a team as code owners December 6, 2021 17:38
@mmanyin
Copy link
Contributor

mmanyin commented Dec 6, 2021

@mathomp4 is there a way to turn OFF the tarfile generation, when running parallel build?

tclune
tclune previously approved these changes Dec 6, 2021
@mathomp4
Copy link
Member Author

mathomp4 commented Dec 6, 2021

@mathomp4 is there a way to turn OFF the tarfile generation, when running parallel build?

Oh. Hmm. Maybe not. I guess I realized a lot of the people that run parallel_build.csh (for the GCM) were often the same people who wanted something like a tarfile of the source code they built. And since parallel_build.csh is more of a "hands-off" build process, most of those users wouldn't be affected by the extra minute or two for the tar'ing.

But it wouldn't be too hard to add an option to parallel_build.csh that turns that "ON" into a "OFF". Give me a hour or so to code something up a la parallel_build.csh -notar or something similar.

Or, if you like, I could just remove any reference to the source-tarfile CMake code with the CTM.

@mathomp4
Copy link
Member Author

mathomp4 commented Dec 6, 2021

@mathomp4 is there a way to turn OFF the tarfile generation, when running parallel build?

Oh. Hmm. Maybe not. I guess I realized a lot of the people that run parallel_build.csh (for the GCM) were often the same people who wanted something like a tarfile of the source code they built. And since parallel_build.csh is more of a "hands-off" build process, most of those users wouldn't be affected by the extra minute or two for the tar'ing.

But it wouldn't be too hard to add an option to parallel_build.csh that turns that "ON" into a "OFF". Give me a hour or so to code something up a la parallel_build.csh -notar or something similar.

Or, if you like, I could just remove any reference to the source-tarfile CMake code with the CTM.

Okay. I'm testing a -notar option now. I'll let you know how it goes (annoyingly I have to build the whole model to test! Fun with CMake! 😄 )

@mmanyin
Copy link
Contributor

mmanyin commented Dec 6, 2021

@mathomp4 The -notar option would be much appreciated, thanks!

@mathomp4
Copy link
Member Author

mathomp4 commented Dec 6, 2021

@mathomp4 The -notar option would be much appreciated, thanks!

Done. I called it -no-tar in the end. Read better to me.

@mathomp4
Copy link
Member Author

Wildly out of date. I can redo if needed.

@mathomp4 mathomp4 closed this Aug 20, 2024
@mathomp4 mathomp4 deleted the feature/mathomp4/update-ctm-to-10195 branch August 20, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants