Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptick FVdycoreCubed to get AdvCore fix #52

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Dec 9, 2024

This PR fixes the initialization of FVdycore in CTM. The effect is to eliminate small negative values that were occasionally returned by AdvecCore. So this PR is a bug fix, and it is non-zero-diff.

@mmanyin mmanyin added the Non 0-diff The changes in this pull request are non-zero-diff label Dec 9, 2024
@mmanyin mmanyin requested a review from a team as a code owner December 9, 2024 20:47
@mmanyin mmanyin merged commit b5c3815 into main Dec 10, 2024
6 checks passed
@mmanyin mmanyin deleted the feature/mmanyin/uptick_FVdycoreCubed branch December 10, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants