Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOCART Data is broken with new MBundle #579

Closed
mathomp4 opened this issue May 6, 2023 · 3 comments
Closed

GOCART Data is broken with new MBundle #579

mathomp4 opened this issue May 6, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mathomp4
Copy link
Member

mathomp4 commented May 6, 2023

The new mbundle code from @atrayano and @bena-nasa seems to have broken GOCART Data:

 Real*4 Resource Parameter: SATSIM_DT:3600.000000
pe=00090 FAIL at line=00136    MBundle_IncrementMod.F90                 <DU::DU is not valid. It likely does not exist in MTR>
pe=00090 FAIL at line=01952    GEOS_PhysicsGridComp.F90                 <status=1>
pe=00090 FAIL at line=01861    MAPL_Generic.F90                         <status=1>
pe=00090 FAIL at line=01315    MAPL_Generic.F90                         <status=1>
pe=00090 FAIL at line=01087    MAPL_Generic.F90                         <status=1>

This new code confuses me enough that I didn't know where to put this issue. I'm not sure if it's a GCM GridComp or GEOSgcm_App issue. So we make it "generic".

CC: @sdrabenh

@bena-nasa
Copy link
Contributor

@pcolarco
I'm pretty sure we can disable this if GOCART2G.data. I will see if I can and report back here. As the question if whatever this is doing, is something that even makes sense when running GOCART2G.data, that a question for a scientist (@amdasilva )who understands what this is reporting and if that is even reportable when running GOCART2G.data

@bena-nasa
Copy link
Contributor

@pcolarco @sdrabenh @mathomp4
Yes it can be disabled. You need to comment out:

# Enable wet scavenging
MTRI_increments::
DU::DU default
SS::SS default
SU::SO4 default
CA.bc::CA.bcphilic default
CA.br::CA.brphilic default
CA.oc::CA.ocphilic default
NI::NO3an1 "NI::NO3an2,NI::NO3an3"
::

and in History remove these fields from whatever collection they are in

                               'MTRI%DU::DUIM'             , 'PHYSICS' , 'DUSV' ,
                               'MTRI%SS::SSIM'             , 'PHYSICS' , 'SSSV' ,
                               'MTRI%CA.oc::CA.ocphilicIM' , 'PHYSICS' , 'OCSV' ,
                               'MTRI%CA.bc::CA.bcphilicIM' , 'PHYSICS' , 'BCSV' ,
                               'MTRI%CA.br::CA.brphilicIM' , 'PHYSICS' , 'BRSV' ,
                               'MTRI%SU::SO4IM'            , 'PHYSICS' , 'SUSV' ,
                               'MTRI%NI::NO3an1IM'         , 'PHYSICS' , 'NISV' ,

@bena-nasa
Copy link
Contributor

I just created new issue #581. This exposes a whole new can of worms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants