Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pcolarco/gocart2 g data instance #211

Merged
merged 9 commits into from
May 12, 2023
Merged

Feature/pcolarco/gocart2 g data instance #211

merged 9 commits into from
May 12, 2023

Conversation

pcolarco
Copy link
Contributor

@pcolarco pcolarco commented Mar 3, 2023

GOCART2G data instances work now

@pcolarco pcolarco requested a review from a team as a code owner March 3, 2023 17:29
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@pcolarco pcolarco added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 3, 2023
@mathomp4
Copy link
Member

mathomp4 commented Mar 3, 2023

@pcolarco Did you actually make this branch against develop?

@pcolarco
Copy link
Contributor Author

pcolarco commented Mar 3, 2023 via email

@mathomp4 mathomp4 changed the base branch from main to develop March 3, 2023 20:09
@mathomp4
Copy link
Member

mathomp4 commented Mar 3, 2023

Yes. Does it not look like so?

The base of the PR was against main. I changed the base so it'll go into develop

@pcolarco
Copy link
Contributor Author

pcolarco commented Mar 3, 2023 via email

@mathomp4 mathomp4 mentioned this pull request Mar 8, 2023
Merged
@mathomp4
Copy link
Member

@pcolarco A note. I might be pushing a change to this PR. Testing with ESMF logging found that this sort of code:

!   Load resource file  
!   -------------------
    cfg = ESMF_ConfigCreate (__RC__)
    call ESMF_ConfigLoadFile (cfg, 'DU2G_instance_'//trim(COMP_NAME)//'.rc', rc=status)

    if (status /= 0) then
        if (mapl_am_i_root()) print*,'DU2G_instance_'//trim(COMP_NAME)//'.rc does not exist! Loading DU2G_GridComp_DU.rc instead'
        call ESMF_ConfigLoadFile (cfg, 'DU2G_instance_DU.rc', __RC__)
    end if

while it works, ESMF throws errors if logging is on:

20230418 074842.245 ERROR            PET00 ESMF_Config.F90:2959 ESMF_ConfigLoadFile_1proc_ Unable to open file  - error opening text file: DU2G_instance_DU.data.rc
20230418 074842.245 ERROR            PET00 ESMF_Config.F90:2898 ESMF_ConfigLoadFile Unable to open file  - unable to load file: DU2G_instance_DU.data.rc

The fix is simple, of course, use inquire() and do the logic off of that. I'm testing fixes now and when I confirm it works, I'll push the change here.

@mathomp4
Copy link
Member

mathomp4 commented May 8, 2023

Note: GOCART Data is currently broken in GEOSgcm main due to the MBundle work:

GEOS-ESM/GEOSgcm#579

amdasilva
amdasilva approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@amdasilva amdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Virginie and Matt has checked this as well.

@amdasilva amdasilva merged commit e3386e8 into develop May 12, 2023
@amdasilva amdasilva deleted the feature/pcolarco/GOCART2G_data_instance branch May 12, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amdasilva amdasilva amdasilva approved these changes

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcolarco @mathomp4 @amdasilva